comment - link with https bug
BotB Academy Bug Reports and Feature Requests
 
 
50597
Level 14 Chipist
bazz
 
 
post #50597 :: 2014.12.15 1:55am
  
  raphaelgoulart liēkd this
Hi, I noticed if a comment link is made with https:// in the URL, the result contains http// or https// I forget which, and therefore the link is broken. Need to add the : in there.. I have temporarily subverted the bug by using no http(s):// in the URL
 
 
54552
Level 27 Chipist
raphaelgoulart
 
 
 
post #54552 :: 2015.03.08 7:21am
bump
this has been around for a (long) while unfixed so why not
 
 
54583
Level 29 Hostist
puke7
 
 
 
post #54583 :: 2015.03.08 4:08pm
  
  MovieMovies1, b00daw, raphaelgoulart, irrlicht project, Chip Champion and goluigi liēkd this
fixed; had a + in the regex where it didn't belong
 
 
54674
Level 23 Chipist
irrlicht project
 
 
 
post #54674 :: 2015.03.10 1:27pm
  
  raphaelgoulart and b00daw liēkd this
Nope, https links still don't work - the : after https is dropped.
 
 
54676
Level 29 Hostist
puke7
 
 
 
post #54676 :: 2015.03.10 3:02pm
  
  raphaelgoulart and Sylveon liēkd this
 
 
54677
Level 23 Chipist
irrlicht project
 
 
 
post #54677 :: 2015.03.10 3:10pm :: edit 2015.03.10 3:11pm
  
  raphaelgoulart and b00daw liēkd this
o rly?
*trollface
 
 
54678
Level 29 Hostist
puke7
 
 
 
post #54678 :: 2015.03.10 3:50pm
  
  irrlicht project, goluigi, raphaelgoulart and b00daw liēkd this
This is why examples in bug reports are useful. *assface
 
 
54741
Level 29 Hostist
puke7
 
 
 
post #54741 :: 2015.03.12 4:16am :: edit 2015.03.12 4:27am
  
  irrlicht project, Sylveon and n00b liēkd this
MUCH RLY WOW


There was a bit of code to add "http://" to a link address using the firki shorthand if it couldn't find "http://" or "ftp://" which would explain the "https://" bug there. I removed this check and the addition of protocol additions. I hope that doesn't break too many links done in firki! :X
 
 
54742
Level 16 Pedagogist
n00b
 
 
post #54742 :: 2015.03.12 4:26am :: edit 2015.03.12 4:30am
  
  raphaelgoulart and Sylveon liēkd this
nice arrow at the external link, so wow, so groovy, so easy now to see tha difference!

but that normblorxs.com link is not really proving httpS works (has an untrusted certificate btw dunno it that's your site too and too lazy to look that up atm)
 
 
54746
Level 29 Hostist
puke7
 
 
 
post #54746 :: 2015.03.12 4:32am
  
  raphaelgoulart and Sylveon liēkd this
 
 
54747
Level 16 Pedagogist
n00b
 
 
post #54747 :: 2015.03.12 4:36am
  
  xterm, raphaelgoulart, irrlicht project and puke7 liēkd this
I find secure google connection extremely contradictionary
 
 
54750
Level 23 Chipist
irrlicht project
 
 
 
post #54750 :: 2015.03.12 5:08am
  
  raphaelgoulart and Baron Knoxburry liēkd this
horray! that was one persistent bugger. glad it's finally dead ;)
 
 

LOGIN or REGISTER to add your own comments!